[simple_fsdp] Use schedule_overlap_bucketing_from_inductor_configs for overlap_passes #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
eellison
approved these changes
Feb 9, 2026
wconstab
approved these changes
Feb 9, 2026
fegin
approved these changes
Feb 9, 2026
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
Some CI failed, I don't think this PR breaks the CI, but I would recommend to resubmit the PR and trigger again later and ensure the CI is green.
Contributor
Author
Yes, I think this is connected with todays github infra failures. I will rebase to verify. |
IvanKobzarev
force-pushed
the
overlap_from_config
branch
from
03f04a1 to
ebcbeda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use schedule_overlap_bucketing_from_inductor_configs that picks default config values.
Previous impl uses default argument values which are not equal to config (E.g. bucketing is off by default).
We want bucketing by default for perf.